Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICE supper nitty - usernameFragment, etc #485

Closed
robin-raymond opened this issue Apr 21, 2016 · 3 comments
Closed

ICE supper nitty - usernameFragment, etc #485

robin-raymond opened this issue Apr 21, 2016 · 3 comments
Labels
1.1 PR exists

Comments

@robin-raymond
Copy link
Contributor

usernameFragment of type DOMString
ICE username.

It's not a username, it's a username fragment. I know i'm being nitty...
@robin-raymond
Copy link
Contributor Author

And another:

The local RTCIceParameters object includes the ICE username fragment and password.

Should read:

The local RTCIceParameters object includes the ICE username fragment and password and other ICE related parameters.

Because ICE lite is another option so it's not technically true.

@robin-raymond robin-raymond changed the title usernameFragment ICE supper nitty - usernameFragment Apr 21, 2016
@robin-raymond robin-raymond changed the title ICE supper nitty - usernameFragment ICE supper nitty - usernameFragment, etc Apr 21, 2016
@aboba
Copy link
Contributor

aboba commented Apr 21, 2016

@robin-raymond Only the remote RTCIceParameters object can include the ICE lite option.

aboba added a commit that referenced this issue Apr 21, 2016
@aboba
ICE nits
ea54311 
Fix for Issue #485
@aboba aboba mentioned this issue Apr 21, 2016
Merged
@robin-raymond
Copy link
Contributor Author

Better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.1 PR exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aboba @robin-raymond