Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is codec.name? #529

Closed
ibc opened this issue May 3, 2016 · 7 comments
Closed

What is codec.name? #529

ibc opened this issue May 3, 2016 · 7 comments

Comments

@ibc
Copy link
Contributor

ibc commented May 3, 2016

name of type DOMString

The MIME media type. Valid types are listed in IANA-RTP-2.

But such a list looks as follows:

captura de pantalla 2016-05-03 a las 23 18 11

So is name something such as PCMA? or audio/PCMA?

BTW: Does it match codec.mimeType in WebRTC draft?

@robin-raymond
Copy link
Contributor

@ibc good question; I think we omit the "audio" because it's in the context of only exclusively audio or video and it easily matches the sdp line description then... at least I think that's the logic behind it.

@robin-raymond
Copy link
Contributor

Yes, codec.mimeType in WebRTC should match.

@aboba
Copy link
Contributor

aboba commented May 4, 2016

We can add a note to that effect in the WebRTC compatibility section.

aboba added a commit that referenced this issue May 4, 2016
Fix for Issue #529
@ibc
Copy link
Contributor Author

ibc commented May 4, 2016

@robin-raymond @aboba I still don't know if name is "PCMA" or "audio/PCMA", nor whether codec.name in WebRTC 1.0 matches it or not.

The PR #532 does not clarify it at all. The "codec MIME type" is ambiguous. The IANA table above clearly shows two columns "Media type" and "Subtype". The spec must be clear regarding this subject and explain which exact field it refers to.

@ibc
Copy link
Contributor Author

ibc commented May 11, 2016

Guys, I insist that the current codec.name description, including the new one in #532, is wrong.

@aboba
Copy link
Contributor

aboba commented May 12, 2016

@ibc It should say "subtype", correct?

@aboba aboba reopened this May 12, 2016
@ibc
Copy link
Contributor Author

ibc commented May 12, 2016

Yep.

aboba added a commit that referenced this issue May 12, 2016
aboba added a commit to w3c/webrtc-pc that referenced this issue May 12, 2016
Fix for Issue w3c/ortc#529 (Opened against ORTC, but applies to WebRTC 1.0 as well).
aboba added a commit to w3c/webrtc-pc that referenced this issue May 16, 2016
Fix for Issue w3c/ortc#529 (Opened against ORTC, but applies to WebRTC 1.0 as well).

Rebase of #637
aboba added a commit that referenced this issue Jun 6, 2016
Fix for Issue #529

Rebase of #543
@aboba aboba closed this as completed Jun 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants