Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unescape after decompression #210

Closed
toberndo opened this issue Apr 9, 2014 · 1 comment
Closed

Unescape after decompression #210

toberndo opened this issue Apr 9, 2014 · 1 comment

Comments

@toberndo
Copy link
Member

toberndo commented Apr 9, 2014

Unescape is currently called after decompression:

https://github.com/openpgpjs/openpgpjs/blob/master/src/compression/jxg.js#L9
https://github.com/openpgpjs/openpgpjs/blob/master/src/packet/compressed.js#L110

This seems to break signatures on binary content of the compressed packet.

Any reason why there is an unescape?

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@iamstarkov
Copy link

may be this is a problem of #204 (input.zip != output.zip)

@twiss twiss closed this as completed Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants