Dev (#58)

* #45 * v0.5.0 * cran comments
openpharma · Apr 3, 2024 · dd5e9e7 · dd5e9e7
1 parent 4f1acd1
commit dd5e9e7
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 30 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,6 +1,6 @@
 Package: simaerep
 Title: Find Clinical Trial Sites Under-Reporting Adverse Events
-Version: 0.4.3.900
+Version: 0.5.0
 Authors@R: c(
     person(given = "Bjoern",
            family = "Koneswarakantha",

diff --git a/NEWS.md b/NEWS.md
@@ -4,6 +4,7 @@
 - add over-reporting probability
 - fix dplyr warnings
 - fix warnings around ggplot and cowplot
+- https://github.com/openpharma/simaerep/issues/45
 
 # simaerep 0.4.3
 - delete performance unit tests (poisson faster than bootstrap) to accommodate CRAN request

diff --git a/R/S3_simaerep.R b/R/S3_simaerep.R
@@ -142,6 +142,7 @@ simaerep <- function(df_visit,
         df_visit = df_visit
       ),
       check = FALSE,
+      progress = progress,
       param_sim_sites
     )
   )

diff --git a/cran-comments.md b/cran-comments.md
@@ -1,37 +1,9 @@
-# resubmission 2 simaerep 0.4.3
-- deleted unit tests which compared function performance when called with different parameters as requested.
-
-Thanks, we see you added
-
-   skip_on_cran() # performance on ci/cd systems is not predictable
-
-but it should not be doing the test anywhere, as WRE explains.
-
-Best,
-Uwe Ligges
-
-# resubmission 1 simaerep 0.4.3
-
-- fix CRAN url in README
-
-- Fix to address issue of failing unit test on CRAN which compared function performance when called with different parameters. This test is now skipped on CRAN. 
-
-Dear maintainer,
-
-Please see the problems shown on
-<https://cran.r-project.org/web/checks/check_results_simaerep.html>.
-
-Please correct before 2023-03-11 to safely retain your package on CRAN.
-
-Do remember to look at the 'Additional issues'.
-
-The CRAN Team
+# submission simaerep v0.5.0
 
 ## Test Results
 
 No notes, warnings or errors
 
-
 ## Test Environments
 
 - Rhub, debian