-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stations jump over each other #82
Comments
It turns out that this is a combination of factors
|
The core issue has been identified. The workflow used to be:
I've removed the QuickSort and replaced it by a laughably* simple other algorithm - which might even perform better given that the lists often will be sorted already. (*the original algorithm might even have started as a joke) Note however that, although it works for now, I'd like to have more robust handling of this case in the future - thus: our database should do this sorting itself. The assumption is:
If such a condition is met, |
This is also a partly upstream issue, where connections are teleporting |
Seems like in some cases the order of stations is incorrect.
See the table below, generated with
dotnet run --ctlc stops=https://graph.irail.be/sncb/stops connections=https://graph.irail.be/sncb/connections today 1hour --validate jump --filter-trip http://irail.be/vehicle/IC723/20191001 --validate jump --dump-connections trip.csv
The text was updated successfully, but these errors were encountered: