Skip to content

Commit

Permalink
fix(levels): Removed type casting of selected level to number to make…
Browse files Browse the repository at this point in the history
… it more flexible; updated documentation related to it
  • Loading branch information
rafa8626 committed Aug 27, 2022
1 parent 1fde38a commit 4f7d21d
Show file tree
Hide file tree
Showing 14 changed files with 68 additions and 68 deletions.
2 changes: 1 addition & 1 deletion dist/esm/controls/levels.js
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ class Levels {
const isPaused = __classPrivateFieldGet(this, _Levels_player, "f").getMedia().paused;
if (option.closest(`#${__classPrivateFieldGet(this, _Levels_player, "f").id}`) && option.classList.contains('op-levels__option')) {
const levelVal = option.getAttribute('data-value');
const level = parseInt(levelVal ? levelVal.replace('levels-', '') : '-1', 10);
const level = levelVal ? levelVal.replace('levels-', '') : '-1';
__classPrivateFieldSet(this, _Levels_defaultLevel, `${level}`, "f");
if (detachMenus) {
__classPrivateFieldGet(this, _Levels_button, "f").setAttribute('data-active-level', `${level}`);
Expand Down
4 changes: 2 additions & 2 deletions dist/esm/media/dash.js
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ class DashMedia extends Native {
return levels;
}
set level(level) {
if (level === 0) {
if (level === '0') {
__classPrivateFieldGet(this, _DashMedia_player, "f").setAutoSwitchQuality(true);
}
else {
Expand All @@ -101,7 +101,7 @@ class DashMedia extends Native {
}
}
get level() {
return __classPrivateFieldGet(this, _DashMedia_player, "f") ? __classPrivateFieldGet(this, _DashMedia_player, "f").getQualityFor('video') : -1;
return __classPrivateFieldGet(this, _DashMedia_player, "f") ? __classPrivateFieldGet(this, _DashMedia_player, "f").getQualityFor('video') : '-1';
}
_assign(event) {
if (event.type === 'error') {
Expand Down
2 changes: 1 addition & 1 deletion dist/esm/media/flv.js
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ class FlvMedia extends Native {
__classPrivateFieldGet(this, _FlvMedia_player, "f").currentLevel = level;
}
get level() {
return __classPrivateFieldGet(this, _FlvMedia_player, "f") ? __classPrivateFieldGet(this, _FlvMedia_player, "f").currentLevel : -1;
return __classPrivateFieldGet(this, _FlvMedia_player, "f") ? __classPrivateFieldGet(this, _FlvMedia_player, "f").currentLevel : '-1';
}
_create() {
const _a = __classPrivateFieldGet(this, _FlvMedia_options, "f") || {}, { configs } = _a, rest = __rest(_a, ["configs"]);
Expand Down
2 changes: 1 addition & 1 deletion dist/esm/media/hls.js
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ class HlsMedia extends Native {
__classPrivateFieldGet(this, _HlsMedia_player, "f").currentLevel = level;
}
get level() {
return __classPrivateFieldGet(this, _HlsMedia_player, "f") ? __classPrivateFieldGet(this, _HlsMedia_player, "f").currentLevel : -1;
return __classPrivateFieldGet(this, _HlsMedia_player, "f") ? __classPrivateFieldGet(this, _HlsMedia_player, "f").currentLevel : '-1';
}
_create() {
const autoplay = !!(this.element.preload === 'auto' || __classPrivateFieldGet(this, _HlsMedia_autoplay, "f"));
Expand Down
10 changes: 5 additions & 5 deletions dist/openplayer.js
Original file line number Diff line number Diff line change
Expand Up @@ -2160,7 +2160,7 @@ var Levels = function () {

if (option.closest("#".concat(levels_classPrivateFieldGet(_this, _Levels_player, "f").id)) && option.classList.contains('op-levels__option')) {
var levelVal = option.getAttribute('data-value');
var level = parseInt(levelVal ? levelVal.replace('levels-', '') : '-1', 10);
var level = levelVal ? levelVal.replace('levels-', '') : '-1';

levels_classPrivateFieldSet(_this, _Levels_defaultLevel, "".concat(level), "f");

Expand Down Expand Up @@ -5009,10 +5009,10 @@ var DashMedia = function (_Native) {
}, {
key: "level",
get: function get() {
return dash_classPrivateFieldGet(this, _DashMedia_player, "f") ? dash_classPrivateFieldGet(this, _DashMedia_player, "f").getQualityFor('video') : -1;
return dash_classPrivateFieldGet(this, _DashMedia_player, "f") ? dash_classPrivateFieldGet(this, _DashMedia_player, "f").getQualityFor('video') : '-1';
},
set: function set(level) {
if (level === 0) {
if (level === '0') {
dash_classPrivateFieldGet(this, _DashMedia_player, "f").setAutoSwitchQuality(true);
} else {
dash_classPrivateFieldGet(this, _DashMedia_player, "f").setAutoSwitchQuality(false);
Expand Down Expand Up @@ -5221,7 +5221,7 @@ var FlvMedia = function (_Native) {
}, {
key: "level",
get: function get() {
return flv_classPrivateFieldGet(this, _FlvMedia_player, "f") ? flv_classPrivateFieldGet(this, _FlvMedia_player, "f").currentLevel : -1;
return flv_classPrivateFieldGet(this, _FlvMedia_player, "f") ? flv_classPrivateFieldGet(this, _FlvMedia_player, "f").currentLevel : '-1';
},
set: function set(level) {
flv_classPrivateFieldGet(this, _FlvMedia_player, "f").currentLevel = level;
Expand Down Expand Up @@ -5484,7 +5484,7 @@ var HlsMedia = function (_Native) {
}, {
key: "level",
get: function get() {
return hls_classPrivateFieldGet(this, _HlsMedia_player, "f") ? hls_classPrivateFieldGet(this, _HlsMedia_player, "f").currentLevel : -1;
return hls_classPrivateFieldGet(this, _HlsMedia_player, "f") ? hls_classPrivateFieldGet(this, _HlsMedia_player, "f").currentLevel : '-1';
},
set: function set(level) {
hls_classPrivateFieldGet(this, _HlsMedia_player, "f").currentLevel = level;
Expand Down
2 changes: 1 addition & 1 deletion dist/openplayer.min.js

Large diffs are not rendered by default.

0 comments on commit 4f7d21d

Please sign in to comment.