fix(ads): Fixed conditional to display properly fatal errors

openplayerjs · Dec 7, 2020 · 77c24bb · 77c24bb
1 parent 11918cc
commit 77c24bb
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 7 deletions.
diff --git a/dist/esm/media/ads.js b/dist/esm/media/ads.js
@@ -332,8 +332,10 @@ class Ads {
             console.warn(`Ad warning: ${error.toString()}`);
         }
         else {
-            if (this.adsManager && fatalErrorCodes.indexOf(error.getErrorCode()) > -1) {
-                this.adsManager.destroy();
+            if (fatalErrorCodes.indexOf(error.getErrorCode()) > -1) {
+                if (this.adsManager) {
+                    this.adsManager.destroy();
+                }
                 console.error(`Ad error: ${error.toString()}`);
             }
             else {

diff --git a/dist/openplayer.js b/dist/openplayer.js
@@ -9379,8 +9379,11 @@ var Ads = function () {
         this.load(true);
         console.warn("Ad warning: ".concat(error.toString()));
       } else {
-        if (this.adsManager && fatalErrorCodes.indexOf(error.getErrorCode()) > -1) {
-          this.adsManager.destroy();
+        if (fatalErrorCodes.indexOf(error.getErrorCode()) > -1) {
+          if (this.adsManager) {
+            this.adsManager.destroy();
+          }
+
           console.error("Ad error: ".concat(error.toString()));
         } else {
           console.warn("Ad warning: ".concat(error.toString()));

diff --git a/dist/openplayer.min.js b/dist/openplayer.min.js
diff --git a/src/js/media/ads.ts b/src/js/media/ads.ts
@@ -774,8 +774,10 @@ class Ads {
             console.warn(`Ad warning: ${error.toString()}`);
         } else {
             // Unless there's a fatal error, do not destroy the Ads manager
-            if (this.adsManager && fatalErrorCodes.indexOf(error.getErrorCode()) > -1) {
-                this.adsManager.destroy();
+            if (fatalErrorCodes.indexOf(error.getErrorCode()) > -1) {
+                if (this.adsManager) {
+                    this.adsManager.destroy();
+                }
                 console.error(`Ad error: ${error.toString()}`);
             } else {
                 console.warn(`Ad warning: ${error.toString()}`);