feat(player): Added unit tests for recent changes in load, play a…

…nd `loadAd` methods; removed unnecessary files and added helper for all unit tests to ensure proper handle on failures; fixes #283
openplayerjs · Oct 3, 2021 · c8ba2db · c8ba2db
1 parent c109bb9
commit c8ba2db
Show file tree

Hide file tree

Showing 13 changed files with 106 additions and 164 deletions.
diff --git a/.nycrc b/.nycrc
diff --git a/karma.conf.js b/karma.conf.js
@@ -7,14 +7,11 @@ module.exports = config => {
             {
                 pattern: 'src/css/**/*.svg', watched: false, included: false, served: true
             },
-            'src/css/*.css',
             { pattern: 'node_modules/expect.js/index.js' },
             { pattern: 'test/player.html', type: 'dom', watched: false },
+            'src/css/*.css',
             'src/js/**/*.ts',
-            'test/utils/*.ts',
-            'test/controls/volume.ts',
-            'test/controls/*.ts',
-            'test/player.ts',
+            'test/**/*.ts',
         ],
         preprocessors: {
             'src/js/**/*.ts': ['karma-typescript', 'coverage'],
@@ -60,6 +57,8 @@ module.exports = config => {
         client: {
             mocha: {
                 asyncOnly: true,
+                forbidOnly: true,
+                bail: true
             }
         },
     });

diff --git a/test/controls/fullscreen.ts b/test/controls/fullscreen.ts
@@ -1,9 +1,10 @@
 import OpenPlayerJS from '../../src/js/player';
+import '../helper';
 
 describe('controls/fullscreen', () => {
     let player = null;
 
-    afterEach(() => {
+    afterEach(done => {
         if (OpenPlayerJS.instances.video) {
             OpenPlayerJS.instances.video.destroy();
         }
@@ -12,6 +13,7 @@ describe('controls/fullscreen', () => {
         }
 
         player = null;
+        done();
     });
 
     it('displays a Fullscreen button in the control bar to the right by default', async () => {

diff --git a/test/controls/play.ts b/test/controls/play.ts
@@ -1,9 +1,10 @@
 import OpenPlayerJS from '../../src/js/player';
+import '../helper';
 
 describe('controls/play', () => {
     let player = null;
 
-    afterEach(() => {
+    afterEach(done => {
         player.pause();
 
         if (OpenPlayerJS.instances.video) {
@@ -14,6 +15,7 @@ describe('controls/play', () => {
         }
 
         player = null;
+        done();
     });
 
     it('displays a Play button in the control bar to the left by default', async () => {
@@ -51,7 +53,7 @@ describe('controls/play', () => {
             startVolume: 0,
         });
         await player.init();
-        return new Promise((resolve, reject) => {
+        return new Promise(resolve => {
             const events = {
                 ended: () => {
                     const play = player.getControls().getContainer()
@@ -63,6 +65,7 @@ describe('controls/play', () => {
                     Object.keys(events).forEach(event => {
                         player.getElement().removeEventListener(event, events[event]);
                     });
+                    player.getElement().currentTime = 0;
                     resolve();
                 },
                 play: () => {
@@ -89,7 +92,7 @@ describe('controls/play', () => {
             try {
                 player.play();
             } catch (err) {
-                reject();
+                throw new Error('error');
             }
         });
     });

diff --git a/test/controls/time.ts b/test/controls/time.ts
@@ -1,13 +1,14 @@
 import OpenPlayerJS from '../../src/js/player';
 import { formatTime } from '../../src/js/utils/time';
+import '../helper';
 
 describe('controls/time', () => {
     let player = null;
 
-    afterEach(() => {
-        player.activeElement().muted = true;
+    afterEach(done => {
         player.destroy();
         player = null;
+        done();
     });
 
     it('displays the current time and duration in the control bar to the left by default', async () => {
@@ -86,28 +87,4 @@ describe('controls/time', () => {
         expect(duration).to.not.be(null);
         expect(duration.textContent).to.equal(formatTime(50));
     });
-
-    it('hides the duration and delimiter when dealing with live media', async () => {
-        const media = document.getElementById('video') as HTMLMediaElement;
-        media.setAttribute('op-live__enabled', 'true');
-
-        player = new OpenPlayerJS('video', {
-            progress: {
-                duration: Infinity,
-            },
-        });
-        await player.init();
-
-        const current = player.getControls().getContainer().querySelector('.op-controls__current') as HTMLInputElement;
-        expect(current).to.not.be(null);
-
-        const delimiter = player.getControls().getContainer().querySelector('.op-controls__time-delimiter') as HTMLElement;
-        expect(delimiter).to.not.be(null);
-        expect(delimiter.getAttribute('aria-hidden')).to.equal('true');
-
-        const duration = player.getControls().getContainer().querySelector('.op-controls__duration') as HTMLInputElement;
-        expect(duration).to.not.be(null);
-        expect(duration.getAttribute('aria-hidden')).to.equal('true');
-        media.removeAttribute('op-live__enabled');
-    });
 });
diff --git a/test/controls/volume.ts b/test/controls/volume.ts
@@ -1,13 +1,15 @@
 import OpenPlayerJS from '../../src/js/player';
+import '../helper';
 
 describe('controls/volume', () => {
     let player = null;
 
-    afterEach(() => {
+    afterEach(done => {
         player.activeElement().muted = true;
         player.activeElement().volume = 0;
         player.destroy();
         player = null;
+        done();
     });
 
     it('displays a Volume button and slider in the control bar to the left by default', async () => {

diff --git a/test/helper.ts b/test/helper.ts
@@ -0,0 +1,6 @@
+function onUncaught(err: string) {
+    console.error(err);
+    process.exit(1);
+}
+
+process.on('unhandledRejection', onUncaught);