Avoid segfault in event notification #1162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delay the checkout/release of the cached event object to ensure the object remains valid until we are done with it. Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit 17bb87f)
|
@ggouaillardet I think this is the only commit missing wrt segfaults when procs fail. Do you see any others that need to come over? |
Track if the collective request has been posted to the host. If it has, then don't remove it from the tracker list and release it - wait for the host to return. If not, then don't let it go to the host. Signed-off-by: Ralph Castain <rhc@pmix.org>
|
bot:ibm:retest |
|
Fixes #1122 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delay the checkout/release of the cached event object to ensure the
object remains valid until we are done with it.
Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit 17bb87f)