v3.1.x: Add "make check" support #1205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a script that runs the Jenkins tests and returns a non-zero status if any of them fail. Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit 2d07a6c)
Scan the output of the Jenkins run to get the list of tests Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit 1f58246)
Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit 2bce385)
Required for "make check" to succeed Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit 2122ec2)
Per chat with @jsquyres, use autogen.pl to assemble a file containing the path names of all components in the code base, then let configure AC_SUBST that string into the run_tests.pl for us. We then let Perl push the result into the environment as an MCA parameter telling the system where to find all the component libraries. Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit 5b3ae33)
When pmix_mca_base_component_path is processed, it is not an error (i.e., we should not abort in the middle) if one of the directories fails to add. Instead, we should warn the user that the directory failed to add, but then keep processing all other directories listed in the path. Signed-off-by: Jeff Squyres <jsquyres@cisco.com> (cherry picked from commit 1019712)
jjhursey
approved these changes
Apr 12, 2019
"make check" can only succeed if the plugins have been installed or "--disable-dlopen" has been passed to configure. The first can't happen in "make distcheck", so force the second for all invocations of "make distcheck" by setting AM_DISTCHECK_CONFIGURE_FLAGS in Makefile.am. Clean up the handling of AM_DISTCHECK_CONFIGURE_FLAGS and DISTCHECK_CONFIGURE_FLAGS in make_dist_tarball. First, with the above fix, passing --disable-dlopen is no longer required. Second, users (and scripts) should set DISTCHECK_CONFIGURE_FLAGS, not AM_DISTCHECK_CONFIGURE_FLAGS. Automake will combine the two options when running "make distcheck", so the right things will happen with this configuration. Signed-off-by: Brian Barrett <bbarrett@amazon.com> (cherry picked from commit e1b4611)
Since we are no longer modifying AM_DISTCHECK_CONFIGURE_FLAGS, we don't want to add config_flags by itself to the distcheck_flags as those are being passed to "make" and not "configure" Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit 84d5189)
Two errors were found. First, the return code when data isn't found can be either PMIX_ERR_NOT_FOUND or PMIX_ERR_PROC_ENTRY_NOT_FOUND - there is no guarantee which might be returned. Only guarantee is that it will not be PMIX_SUCCESS. Thus, the test has to be a little more flexible when checking for error codes. Second, when multiple servers are trying to mimic a multi-node setup, each server is required to provide a proc map of the entire job - not just the clients local to it. Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit 96c8765)
If the system or user default component repository path doesn't exist, then don't bark about it - there is no requirement that these exist. Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit 4035bd4)
Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit e49b100)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.