Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix case of multiple launcher calls in job script #1222

Merged
merged 1 commit into from
May 2, 2019

Conversation

rhc54
Copy link
Contributor

@rhc54 rhc54 commented Apr 22, 2019

When a launcher is invoked multiple times in a job script, each
invocation will have the same "client". The job-level info and tracking
objects are released after each invocation, so we have to recreate them.

Fixes #1211

Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit 04fd3e7)

When a launcher is invoked multiple times in a job script, each
invocation will have the same "client". The job-level info and tracking
objects are released after each invocation, so we have to recreate them.

Fixes openpmix#1211

Signed-off-by: Ralph Castain <rhc@pmix.org>
(cherry picked from commit 04fd3e7)
@rhc54 rhc54 requested a review from dsolt May 1, 2019 03:01
@rhc54 rhc54 self-assigned this May 1, 2019
@rhc54 rhc54 added the bug label May 1, 2019
@rhc54 rhc54 added this to the v3.1.3 milestone May 1, 2019
@jjhursey
Copy link
Member

jjhursey commented May 2, 2019

@dsolt can you confirm that this PR addresses the issue that you were seeing?

@dsolt
Copy link
Contributor

dsolt commented May 2, 2019

I get this when I run:

Program received signal SIGSEGV, Segmentation fault.
0x000010000081468c in pmix_pointer_array_get_item (table=0x3fffffff8a18, element_index=15)
at /smpi_tmp/dsolt/pmix/pmix-master/src/class/pmix_pointer_array.h:131
131 p = table->addr[element_index];
Missing separate debuginfos, use: debuginfo-install glibc-2.17-222.el7.ppc64le zlib-1.2.7-17.el7.ppc64le
(gdb) print element_index
$1 = 15
(gdb) print table->addr
$2 = (void **) 0x80

I will investigate, but I wanted to provide some status before our weekly meeting

@dsolt
Copy link
Contributor

dsolt commented May 2, 2019

Oops, I had some v4 pmix/.so files laying around that it was trying to pick up. So, I tested this without our workaround of unsetting everything in the environment and this worked for me!

@rhc54
Copy link
Contributor Author

rhc54 commented May 2, 2019

woohoo! Thanks

@rhc54 rhc54 merged commit 6564b07 into openpmix:v3.1 May 2, 2019
@rhc54 rhc54 deleted the cmr31/ml branch May 2, 2019 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants