PTL/usock: usock doesn't support Tools, fail query for this case.
#1271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Port this portion from 6bbbb4b in master. Signed-off-by: Artem Polyakov <artpol84@gmail.com>
|
Because it was missing it looks like v3.1 is passing cross-version test while it shouldn't. |
|
The IBM CI (Cross-version) build failed! Please review the log, linked below. Gist: https://gist.github.com/4149895039ab7aa10c7156ef8cb4d826 |
|
Thanks for tracking this down! We probably should update the xversion test to more accurately reflect what combinations really should support tools - it may be that tool xversion support isn't as pervasive in the older versions (and doesn't need to be as adoption has come later). |
rhc54
approved these changes
May 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port this portion from 6bbbb4b in master.
Signed-off-by: Artem Polyakov artpol84@gmail.com