Resolve a problem with updated "put" key-value pairs #3206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correctly retrieve updated "put" keys. In this release series, the mechanism for executing "refresh" is done by direct modex, which while inefficient does at least retrieve the data. In order for it to work with refresh, we have to pass the key to the remove daemon so it can specifically retrieve it. Not sure why the updated data isn't included in the "fence" that is being executed after the values have been changed. Nor why the insertion of a "group construct" call before updating the values should have any impact on the operation as the two are completely orthogonal. However, I do note that simply disabling the dstore resolves all observed problems. So I suspect we are again running up against the limitations of that subsystem. Note: this change requires a corresponding change on the host server's handling of the direct modex request. Signed-off-by: Ralph Castain <rhc@pmix.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctly retrieve updated "put" keys. In this release series, the mechanism for executing "refresh" is done by direct modex, which while inefficient does at least retrieve the data. In order for it to work with refresh, we have to pass the key to the remove daemon so it can specifically retrieve it.
Not sure why the updated data isn't included in the "fence" that is being executed after the values have been changed. Nor why the insertion of a "group construct" call before updating the values should have any impact on the operation as the two are completely orthogonal.
However, I do note that simply disabling the dstore resolves all observed problems. So I suspect we are again running up against the limitations of that subsystem.
Note: this change requires a corresponding change on the host server's handling of the direct modex request. See openpmix/prrte#1873
This change is specific to the v4.2 branch - not applicable to any other branch.
bot:notacherrypick
Fixes #3201