Visual Homing returns true when no fiducial is found

[cncmachineguy]

Problem Report

Describe the Issue

If no Home_fiducial is found, visualHoming returns true and the machine thinks it is homed.

Steps to Reproduce

If you use visual homing already, just cover the fid so it can not be seen.
If you do not use visual homing, simply enable it
Now home the machine as normal

Expected Result

I expect when the visual homing is done, if no fiducial is found an error might be thrown, or at the least do not set the machine as homed.

Actual Result

Machine is set as homed and acts ready to go as if it is homed.

Notes, Log Files, Screen Captures, Videos, etc. to Show the Issue

2019-03-03 23:35:08.977 ReferenceFiducialLocator DEBUG: No matches found!
2019-03-03 23:35:08.981 GcodeDriver DEBUG: sendCommand(G92X0Y0Z0C0, -1)...
2019-03-03 23:35:08.982 GcodeDriver TRACE: [serial://COM7] >> G92X0Y0Z0C0
2019-03-03 23:35:08.986 GcodeDriver TRACE: [serial://COM7] << ok
2019-03-03 23:35:08.986 GcodeDriver DEBUG: sendCommand(serial://COM7 G92X0Y0Z0C0, -1) => [ok]
2019-03-03 23:35:08.986 GcodeDriver DEBUG: sendCommand(G4P0, -1)...
2019-03-03 23:35:08.986 GcodeDriver TRACE: [serial://COM7] >> G4P0
2019-03-03 23:35:08.990 GcodeDriver TRACE: [serial://COM7] << ok
2019-03-03 23:35:08.990 GcodeDriver DEBUG: sendCommand(serial://COM7 G4P0, -1) => [ok]
2019-03-03 23:35:08.992 ReferenceMachine DEBUG: setHomed(true)

[doppelgrau]

I think this can be closed, reference head throws an exception if no location is found, reference machine does not catch it (only exceptions in scripting).
Guess had been solved without closing the bug?! (commit 3e64b57)

[markmaker]

Guess had been solved without closing the bug?! (commit 3e64b57)

Yes this was solved, but in 2fa440c, i.e. #1035.

[cncmachineguy]

Thanks All :)

…

On Sun, Apr 25, 2021 at 5:45 PM Jason von Nieda ***@***.***> wrote: Closed #816 <#816>. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#816 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AI7TSFLHHBPCQIXMNBQOXO3TKSEQZANCNFSM4G6V3X2A> .