Mjpg camera feature #1075
Merged
Mjpg camera feature #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me! Could you mention what kind of camera it is so that others can consider the same? |
|
I am using this kind of camera. Full disclosure, this is a "smart" camera that my son and I made for robotics competitions. It has the ability to run OpenCV pipelines but right now I'm just using it as an IP camera. |
|
Great, thanks @desertgreg! |
vonnieda
added a commit
that referenced
this pull request
Dec 23, 2020
* develop: Added possibility to disable ContactProbeNozzle actuator temporarily. To (#1026) ReferenceDragFeeder works with 0402 parts with vision enabled and dis… (#1088) a feeder in feeder's list is grayed out if no active placement uses it. (#1068) Closes #1005: Replace actuator text field with combobox (#1080) Feature / Global Axes and Framework for Enhanced Motion Control (#1035) Fix for issue 755 "ReferenceStripFeeder Breaks When Part Pitch > Hole to Hole Distance" (#1083) Improved loop syntax, fixed code to update the part info whenever the combo box is changed. (#1077) MjpgCaptureCamera was missing image transform support. Added the missing code so the image trasnform settings now work correctly. (#1078) set list length of combo boxes to 20 items. (#1069) Implemented part count display on the ReferenceStripFeederConfigurationWizard (#1076) Mjpg camera feature (#1075) # Conflicts: # src/main/java/org/openpnp/machine/reference/ReferenceMachine.java
|
Hi @desertgreg Just wanted to tell you this is great! I wanted to test it for #1095 I entered more or less the first online MJPG cam I found, and it worked:
Cool stuff!! I changed quite some things, you can follow #1095 to see what and why. _Mark |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds MjpgCaptureCamera and MjpgCaptureCameraWizard to OpenPNP. This class allows you to use IP cameras which output Mjpg streams.
Justification
My pick and place machine is using an Mjpg camera for its up camera and this feature should be generally useful for anyone who wants to use one of these cameras.
Instructions for Use
In the machine configuration GUI you can add an MjpgCaptureCamera anywhere that you are able to use any other type of camera (e.g. OpenPnpCaptureCamera, OpenCvCamera, etc)
There is currently only one setting which is the IP address and port number to pull the MJPG stream from:
Implementation Details
org.openpnp.spiororg.openpnp.modelpackagesmvn testsucceeded without errors.