Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Actuator Profiles, Camera Lights -- Round 2 #1106

Conversation

markmaker
Copy link
Collaborator

@markmaker markmaker commented Jan 16, 2021

Description

This is a continuation of #1095.

  • Stricter rules to actuate Actuators in Machine Tasks required some bug-fixes in AutoFeeder where actions were not executed in Machine Tasks.
  • Auto-select tool in Machine Controls based on user action.
  • Automatically reset Virtual Z when moving out of a 5mm radius to prevent unexpected movement.
  • EDIT: the Pipeline Editor will also auto-select the correct Camera View. And it will finally align itself on top of the main Frame (90% coverage).

Justification

See discussion here:
https://groups.google.com/g/openpnp/c/uFkgFErohTI/m/_1orOmMDCQAJ

Instructions for Use

See #1095.

In addition, there is the Auto Tool Select option in the Machine.

Auto Tool Select Option

Implementation Details

  1. New test round in the simulation machine with two nozzles added.
  2. Did follow the coding style.
  3. Changes in the org.openpnp.spi or org.openpnp.model (actually a simplification).
  4. Successful run of mvn test before submitting the Pull Request.

* Purge Virtual Z when moving out of 5mm radius.
@markmaker
Copy link
Collaborator Author

We seem to have had some git FUBAR situation. I reset all branches hard and cherry-picked the changes. Now it seems to work.

_Mark

@markmaker markmaker merged commit 156ca89 into openpnp:test Jan 16, 2021
@markmaker markmaker deleted the feature/actuator-camera-light-and-profiles--2b branch January 16, 2021 21:26
@markmaker markmaker added the testing-round A testing round, integrating several, partailly related changes. label Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing-round A testing round, integrating several, partailly related changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant