Feature/Automatic Machine Calibration using Issues & Solutions - Round 2 #1253
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on #1248, this is an enhancement and bug-fix round based on test version feed-back,
IssuePanel
using right mouse click. This is signalled by quickly flashing the text.GcodeAsyncDriver
to aGcodeDriver
) are now only severitySuggestion
(and notFundamental
) and they do no longer (reverse-) block dependent solutions.ImageCamera
orSimulatedUpLookingCamera
with a realOpenPnpCaptureCamera
, the old/new camera is now properly (un)registered in theCameraView
. No OpenPnP restart required. Furthermore, should a USB device have been assigned in the meantime, the camera device is properly closed when the solution is undone.AbstractCoordinateAxis.convertFromSystem()
(missing "s"), also inReferenceControllerAxis
.toHeadLocation()
transformation to the axis coordinate to camera transformation in backlash calibration.HeadSolutions
will now discover the initial Nozzle configuration of a migrated machine. If the machine has a Milestone other than Welcome (which is only assumed for machines, that still have aNullDriver
etc.), the solution is marked as already solved, i.e. it will be hidden by default.Length.isInitialized()
method.Thanks to all testers.
Justification
See the discussion in the testing round:
https://groups.google.com/g/openpnp/c/dBg7txMB0R0/m/5UpXsvJMBwAJ
Instructions for Use
See #1248
Implementation Details
machine.xml
.org.openpnp.model.Length.isInitialized()
.mvn test
before submitting the Pull Request.