Return from estimateCaptureFps after timeout even if no frames are actually captured. #1518
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes FPS Test button causing OpenPnP to hang
if camera is lost/unplugged or stops receiving frames.
Description
estimateCameraFps function has a while loop which only exits when the camera indicates it has a new frame.
Assuming hasNewFrame returns false when the camera is unplugged then exiting the while loop when the timeout expires will prevent OpenPnP from hanging endlessly.
Justification
Hopefully fixes bug reported on the Google group.
Instructions for Use
N/A. Problem was seen on loss of camera during an FPS test.
Implementation Details