Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature / SimulationModeMachine: add option to (not) replace drivers with GcodeServer #1561

Conversation

markmaker
Copy link
Collaborator

Description

Make it optional to replace drivers with GcodeServer in simulation mode. The new option defaults to true, i.e., it behaves as before.

Justification

It can make sense to drive external controllers using the simulation machine, performing a simulated job.

See actual example here:
https://groups.google.com/g/openpnp/c/IshRY1IM80w/m/cmKHbbO6BQAJ

Instructions for Use

The new option is on the Simulation Mode tab of the machine:

Simulation Mode

After changing the option, press Apply and disable and re-enable the machine for the new option state to become effective.

Implementation Details

  1. Tested in simulation, the optional driver replacing works.
  2. Did follow the coding style.
  3. No changes in the org.openpnp.spi or org.openpnp.model packages.
  4. Successful mvn test before submitting the Pull Request.

The new option defaults to true, i.e., it behaves as before.
@markmaker markmaker merged commit 3e01f14 into openpnp:test May 19, 2023
4 checks passed
@markmaker markmaker deleted the feature/simulation-mode-replacing-drivers-option branch May 19, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant