Feature / SimulationModeMachine: add option to (not) replace drivers with GcodeServer #1561
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make it optional to replace drivers with GcodeServer in simulation mode. The new option defaults to true, i.e., it behaves as before.
Justification
It can make sense to drive external controllers using the simulation machine, performing a simulated job.
See actual example here:
https://groups.google.com/g/openpnp/c/IshRY1IM80w/m/cmKHbbO6BQAJ
Instructions for Use
The new option is on the Simulation Mode tab of the machine:
After changing the option, press Apply and disable and re-enable the machine for the new option state to become effective.
Implementation Details
org.openpnp.spi
ororg.openpnp.model
packages.mvn test
before submitting the Pull Request.