New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backlash compensations capabilities added for X/Y Axis #400
Conversation
# Conflicts: # src/main/java/org/openpnp/machine/reference/driver/GcodeDriver.java
@sp-apertus This looks very good! I have one tiny change request and then we can merge this. Can you please move the three new fields in the wizard to a single line? Vertical space in the wizards is at a premium so I'd like to minimize how much of it we use. Thanks, |
I rearranged everything into two grid rows to save vertical space, its a
bit wide now because the labels are long and the textfields are a lot wider
than their content...
[image: Inline image 1]
so I reduced the textfield widths a bit:
[image: Inline image 2]
git commited.
Regards Sebastian
…On Tue, Jan 3, 2017 at 5:00 PM, Jason von Nieda ***@***.***> wrote:
@sp-apertus <https://github.com/sp-apertus> This looks very good! I have
one tiny change request and then we can merge this. Can you please move the
three new fields in the wizard to a single line? Vertical space in the
wizards is at a premium so I'd like to minimize how much of it we use.
Thanks,
Jason
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#400 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AD13-U6HUqWWwX_pbb0jsys0gB8HSKrPks5rOnCpgaJpZM4LZvPl>
.
|
Thanks @sp-apertus, but what I meant is just to put the three new fields themselves on a new line instead of on two new lines. Don't worry about it, though. I will merge this and rearrange the fields a bit. Thank you for adding this! |
Updates to the wizard pushed. Thanks again @sp-apertus! |
My pleasure :D
…On Tue, Jan 3, 2017 at 7:04 PM, Jason von Nieda ***@***.***> wrote:
Updates to the wizard pushed. Thanks again @sp-apertus
<https://github.com/sp-apertus>!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#400 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AD13-cKwLs888NCsAnWXFYD-KIz8h2eAks5rOo3CgaJpZM4LZvPl>
.
|
The idea is to always move to a point defined by BacklashOffsetX / BacklashOffsetY from the target coordinates first and then move slowly (speed multiplied by the BacklashFeedRateFactor) to the target coordinates.
without backlash compensation:
with backlash compensation:
The Gcode MOVETO command with backlash compensation is meant to look like this:
G0 {BacklashOffsetX:X%.4f} {BacklashOffsetY:Y%.4f} {Z:Z%.4f} {Rotation:A%.4f} F{FeedRate:%.0f}
G1 {X:X%.4f} {Y:Y%.4f} {Z:Z%.4f} {Rotation:A%.4f} F{BacklashFeedRate:%.0f}
This does not compensate for backlash on axes A and Z as I did not consider that too relevant but if people see a real world benefit I am happy to reconsider adding those as well.
I did not get maven to install so I cant run mvn test from inside eclipse yet but I tested the changes with a fresh configuration directory manually.