Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont-refresh-if-cookie #7

Merged
merged 3 commits into from
Sep 19, 2023
Merged

Dont-refresh-if-cookie #7

merged 3 commits into from
Sep 19, 2023

Conversation

mre
Copy link
Contributor

@mre mre commented Sep 19, 2023

Tested locally with Anchor credentials (via email) and Spotify credentials (via Google Social Login / SSO).

Ensure that cookie messages persist on the openpodcast.dev page even after cookies have been deleted by the background worker for security purposes. This change enhances user experience by preventing the display from resetting after initial cookie acquisition.
@mre mre requested a review from woolfg September 19, 2023 14:48
Copy link
Contributor

@woolfg woolfg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mre mre merged commit 8b7320d into main Sep 19, 2023
@mre mre deleted the dont-refresh-if-cookie branch September 19, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants