Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New request flow #8

Merged
merged 5 commits into from
Feb 27, 2024
Merged

New request flow #8

merged 5 commits into from
Feb 27, 2024

Conversation

mre
Copy link
Contributor

@mre mre commented Feb 26, 2024

  • Added support for local development (localhost in manifest)
  • Added support for message-passing to background worker (a.k.a. "new flow"). This avoid manipulating the DOM and instead the frontend can poll the state of the Spotify credentials.
  • Made the code more idiomatic (I hope) and added better error-handling.
  • Kept compatibility with openpodcast.dev. We can remove that as a next step after the migration.

@mre
Use messages instead of DOM manipulation
84f20e6 
This new extension flow uses messages to `background.js` to retrieve the credentials instead of manipulating the DOM.
The old flow is still supported, because it is used on openpodcast.dev
@mre
Update based on best-practices / make more idiomatic
179712d
@mre
cleanup
8d12b14
@mre
clarifications; return null
4a5c3ba
@mre
clean up cookies after retrieval
880f4c9
@mre mre requested a review from woolfg February 26, 2024 19:48
woolfg
woolfg approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@woolfg woolfg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quite nice the "new way"

@mre mre merged commit ef9b718 into main Feb 27, 2024
@mre mre deleted the new-flow branch February 27, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woolfg woolfg woolfg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mre @woolfg