Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decidim upgrade to 0.28 #124

Open
wants to merge 40 commits into
base: main
Choose a base branch
from
Open

Decidim upgrade to 0.28 #124

wants to merge 40 commits into from

Conversation

antopalidi
Copy link
Member

@antopalidi antopalidi commented Mar 18, 2024

Screenshot 2024-03-18 at 12 25 09
Screenshot 2024-03-25 at 19 12 37
Screenshot 2024-03-22 at 10 43 44

@antopalidi antopalidi self-assigned this Mar 18, 2024
@microstudi
Copy link
Contributor

@antopalidi remember to update the plugin version to 0.3.0 and add it to the Readme table

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 84.50704% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 93.10%. Comparing base (76957bf) to head (e1f94f1).

Files Patch % Lines
...rticipatory_documents/admin/sections_controller.rb 25.00% 3 Missing ⚠️
...cipatory_documents/admin/annotations_controller.rb 83.33% 2 Missing ⚠️
...ory_documents/admin/suggestion_notes_controller.rb 50.00% 2 Missing ⚠️
...dels/decidim/participatory_documents/suggestion.rb 33.33% 2 Missing ⚠️
...models/decidim/participatory_documents/document.rb 0.00% 1 Missing ⚠️
lib/tasks/decidim_participatory_documents.rake 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #124      +/-   ##
==========================================
- Coverage   93.50%   93.10%   -0.40%     
==========================================
  Files          67       65       -2     
  Lines        1540     1451      -89     
==========================================
- Hits         1440     1351      -89     
  Misses        100      100              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@microstudi microstudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, but as Decidim 0.28.1 is out, can we make the update (as suggested in the comments) before mergin?

Comment on lines +12 to +14
# rubocop:disable Rails/ThreeStateBooleanColumn
t.boolean :answer_is_published, default: false
# rubocop:enable Rails/ThreeStateBooleanColumn
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# rubocop:disable Rails/ThreeStateBooleanColumn
t.boolean :answer_is_published, default: false
# rubocop:enable Rails/ThreeStateBooleanColumn
t.boolean :answer_is_published, default: false, null: false

Instead of the cop, let's just remove the null no?

DECIDIM_VERSION = "0.27.5"
COMPAT_DECIDIM_VERSION = [">= 0.27.0", "< 0.28"].freeze
VERSION = "0.3.0"
DECIDIM_VERSION = "0.28"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
DECIDIM_VERSION = "0.28"
DECIDIM_VERSION = "0.28.1"

Let's upgrade to 0.28.1

Comment on lines +4 to +5
RSpec/RemoveConst:
Enabled: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants