Hide proposals without reporting

[antopalidi]

• Add a configuration option for this module Decidim::ReportingProposals.allow_admins_to_hide_proposals
• If configuration active, override the view when managing a proposal in the admin, add a button saying "hide this proposal" (the flag in the mockup). Show the same modal window that appears in the frontend side when you press the "report" flag button.
• Add a controller in this module that handles the action of creating a report and hiding the content (use existing commands CreateReport and/or HideResource from decidim).
• Add a entry to the spec/lib/overrides_spec.rb to keep track of the overriden view file.
• Prevent to generate notifications/emails to other admins if hidden by the admin. Affected user should still receive their notification.
• When hiding, use the same modal with the options on why are you hidding that (can be used as confirmation dialog)
• Add behaviour specs for this

[microstudi]

Thanks Anna for this great work.
I specially like the new user flow that you created here. Nice.

A part from completing tests, we should change one structural decision here (see comments).
You've decided to override the current proposals engine, I'm not very fond of this, I think is too invasive. I propose to handle the action hide in house, ie: let's create a custom controller for this: Decidim::ReportingProposals::Admin::ReportingProposalsController

The route for this hide action should be defined in a new file lib/decidim/reporting_proposals/admin_engine.rb.

We need to include this file in a new "require" statement in lib/decidim/reporting_proposals.rb

That would be it I think!

[codecov-commenter]

Codecov Report

Base: 95.72% // Head: 95.21% // Decreases project coverage by -0.50% ⚠️

Coverage data is based on head (a2a16dd) compared to base (fc34321).
Patch coverage: 93.75% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
- Coverage   95.72%   95.21%   -0.51%     
==========================================
  Files          10       16       +6     
  Lines         187      251      +64     
==========================================
+ Hits          179      239      +60     
- Misses          8       12       +4     

Impacted Files	Coverage Δ
...idim/reporting_proposals/create_report_override.rb	66.66% <66.66%> (ø)
.../reporting_proposals/admin/proposals_controller.rb	92.85% <92.85%> (ø)
.../reporting_proposals/admin/hide_flag_modal_cell.rb	100.00% <100.00%> (ø)
...eporting_proposals/admin/application_controller.rb	100.00% <100.00%> (ø)
lib/decidim/reporting_proposals.rb	100.00% <100.00%> (ø)
lib/decidim/reporting_proposals/admin.rb	100.00% <100.00%> (ø)
lib/decidim/reporting_proposals/admin_engine.rb	100.00% <100.00%> (ø)
lib/decidim/reporting_proposals/config.rb	100.00% <100.00%> (ø)
lib/decidim/reporting_proposals/engine.rb	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[microstudi]

good job!