Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLA accepted flag to database #1013

Merged
merged 1 commit into from Feb 8, 2021
Merged

Conversation

jt-nti
Copy link
Collaborator

@jt-nti jt-nti commented Feb 7, 2021

Signed-off-by: James Taylor jt-git@nti.me.uk

Signed-off-by: James Taylor <jt-git@nti.me.uk>
@jt-nti
Copy link
Collaborator Author

jt-nti commented Feb 7, 2021

Does this look like a reasonable first step for #72?

@Floppy
Copy link
Member

Floppy commented Feb 8, 2021

Yep, makes sense to me!

@jt-nti jt-nti marked this pull request as ready for review February 8, 2021 11:17
@jt-nti
Copy link
Collaborator Author

jt-nti commented Feb 8, 2021

Any idea why the checks aren't running?

@Floppy Floppy merged commit bd36575 into openpolitics:master Feb 8, 2021
@Floppy
Copy link
Member

Floppy commented Feb 8, 2021

No, must be a fork thing? It looks fine so I'll merge.

@Floppy
Copy link
Member

Floppy commented Feb 8, 2021

Hopefully it will all be fine on master 🤠

@jt-nti
Copy link
Collaborator Author

jt-nti commented Feb 8, 2021

What's the worst that could happen?! Will the db get migrated? 😬
Now I just need to figure out how to make use of it without breaking all the things... I was wondering about attempting to put a link to the cla with an "I agree" checkbox in https://github.com/openpolitics/groupthink/blob/master/app/views/edit/message.html.erb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants