Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XMLHandler outputs wrong bitPerSample in MIX #108

Closed
carlwilson opened this issue Sep 7, 2016 · 3 comments
Closed

XMLHandler outputs wrong bitPerSample in MIX #108

carlwilson opened this issue Sep 7, 2016 · 3 comments
Assignees
@tledoux
Labels
bug A product defect that needs fixing legacy Legacy bugs that require testing to establish status

Comments

@carlwilson
Copy link
Member

carlwilson commented Sep 7, 2016 •
edited
Loading

While using XMLHandler, JHOVE creates incorrect number (2) of mix:bitsPerSampleValue MIX tags:

<mix:ImageColorEncoding>
  <mix:BitsPerSample>
    <mix:bitsPerSampleValue>8</mix:bitsPerSampleValue>
    <mix:bitsPerSampleValue>8</mix:bitsPerSampleValue>
    <mix:bitsPerSampleUnit>integer</mix:bitsPerSampleUnit>
  </mix:BitsPerSample>
  <mix:samplesPerPixel>3</mix:samplesPerPixel>
</mix:ImageColorEncoding>

The attached patch fixes iteration over the array of bitsPerSampleValue starting from 0. The accompanying patch is available from SourceForge: https://sourceforge.net/p/jhove/patches/_discuss/thread/5d7c7155/77d4/attachment/XmlHandler.patch
@carlwilson carlwilson added bug A product defect that needs fixing legacy legacy Legacy bugs that require testing to establish status labels Sep 7, 2016
@carlwilson carlwilson added this to the Legacy testing backlog cleared milestone Sep 7, 2016
@tledoux
Copy link
Contributor

tledoux commented Sep 7, 2016

This patch has been applied in commit 2448772.

Closing #108

@tledoux
Copy link
Contributor

tledoux commented Apr 24, 2017

As stated before. Closed

@tledoux tledoux closed this as completed Apr 24, 2017
@carlwilson
Copy link
Member Author

Nice, thanks @tledoux

rgfeldman added a commit to rgfeldman/jhove that referenced this issue Apr 10, 2019
@rgfeldman
issue openpreserve#108
27ef8b1
rgfeldman added a commit to rgfeldman/jhove that referenced this issue Apr 10, 2019
@rgfeldman
issue openpreserve#108
50f319f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tledoux tledoux

Labels
bug A product defect that needs fixing legacy Legacy bugs that require testing to establish status
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@carlwilson @tledoux