Support WAV chunks > Integer.MAX_INT #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Refactored merge against new Maven project structure: #37, this will be closed when the new PR is merged if satisfactory. |
|
I believe that this is now closed by #37 that took into account location changes following the Maven refactoring. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses #9, including that truncated WAV as a test file. It seems the chunk size was assumed to be less that Integer.MAX_INT, which is problematic because the size can be up to that of an unsigned integer (which is that maximum chunk size for WAV I think - I wonder what happens if the WAV is larger still?).
I added the sample3.wav and created a unit test that reproduced the error, and then tracked down enough (int) operations to make it work again. This does not mean this issue will be resolved for other format modules, although there were modifications in a few modules to account for ModuleBase.skipBytes now returning a long rather than an int.