Add ICC Profile name for JPEG and TIFF files. #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validate ICC profile using java standard ICC_Profile class Decode v2 and v4 ICC Profiles description according to Specification ICC.1:2001-04 http://www.color.org/ICC_Minor_Revision_for_Web.pdf Specification ICC.1:2010-12 http://www.color.org/ICC1-V41.pdf Add unit test for v2 and v4 ICC profiles. Test output of iccProfileName in NisoImageMetadata v0.2, v1.0 and v2.0. Extract ICCProfile from TIFF tag ICCProfile. Extracy ICCProfile from APP2 segment in JPEG. Fixes openpreserve#61 Fixes openpreserve#62
Codecov Report
@@ Coverage Diff @@
## integration #249 +/- ##
================================================
+ Coverage 40.36% 40.5% +0.14%
- Complexity 3128 3136 +8
================================================
Files 392 392
Lines 31400 31474 +74
Branches 6114 6123 +9
================================================
+ Hits 12674 12748 +74
+ Misses 16349 16337 -12
- Partials 2377 2389 +12
Continue to review full report at Codecov.
|
carlwilson
approved these changes
May 11, 2017
There was a problem hiding this comment.
Hi @tledoux, saw your message and had already had a look and have approved this now.
Closed
rgfeldman
added a commit
to rgfeldman/jhove
that referenced
this pull request
Apr 10, 2019
rgfeldman
added a commit
to rgfeldman/jhove
that referenced
this pull request
Apr 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validate ICC profile using java standard ICC_Profile class
Decode v2 and v4 ICC Profiles description according to
Specification ICC.1:2001-04 http://www.color.org/ICC_Minor_Revision_for_Web.pdf
Specification ICC.1:2010-12 http://www.color.org/ICC1-V41.pdf
Add unit test for v2 and v4 ICC profiles.
Test output of iccProfileName in NisoImageMetadata v0.2, v1.0 and v2.0.
Extract ICCProfile from TIFF tag ICCProfile.
Extracy ICCProfile from APP2 segment in JPEG.
Fixes #61
Fixes #62