Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WAVE: Fix parse error in Associated Data List #309

Merged
merged 5 commits into from Mar 28, 2018
Merged

WAVE: Fix parse error in Associated Data List #309

merged 5 commits into from Mar 28, 2018

Commits on Feb 7, 2018

  1. FIX: Parse error in WAVE Associated Data List.

    When reading an Associated Data List's sub-chunks JHOVE eats bytes
    according to the value of the `bytesLeft` variable which is initialized
    with the Associated Data List's size. Since the size encompasses not
    only the sub-chunks but also the Associated Data List's 4 bytes sized
    type ID field JHOVE should subtract 4 bytes from the `bytesLeft`
    variable before it starts reading sub-chunks.
    marhop committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    b1c9c57 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2018

  1. FIX: Trim strings in WAVE Note and Label chunks.

    Those strings are NULL terminated, calling trim() removes the NULL byte.
    
    It also removes all trailing whitespace, which may not be desired.
    Something like `str.replaceFirst("\0$", "")` would be more precise.
    Anyway, trim() is used in this commit to be consistent with the rest of
    the WAVE module where trim() is used as well.
    marhop committed Feb 8, 2018
    Configuration menu
    Copy the full SHA
    11c9a0e View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2018

  1. Configuration menu
    Copy the full SHA
    b7a9601 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2018

  1. Configuration menu
    Copy the full SHA
    efa9203 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2018

  1. Configuration menu
    Copy the full SHA
    9327e3b View commit details
    Browse the repository at this point in the history