FIX - PDF module, various processing errors #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixed spacing errors; and - merged test data and utils.
- added basic JavaDoc to `TestUtils`; - added extra convenience method for file testing; and - fixed whitespace issues.
- now uses `TestUtils`; and - basic JavaDoc.
- added test suite to run individual aspect tests; and - tests re-named by PDF Feature, e.g. `HeaderTests`.
- added complete set of iPres corpus header tests to resource folder; - added full set of iPres corpus header unit tests; - changed name of minimal valid test file to T00_000_minimal-valid.pdf; - moved header test files to dedicated folder; - fixed whitespace issues; and - JavaDoc for tests.
- added all iPres corpus document catalog test cases; - unit tests for document catalog iPres Corpus resources; - fixed duplicate error message for document catalog type; and - moved document catalog test cases to specific folder.
- added explicit catch for missing pages dictionary lookup; and - amended test message value.
- added \Type key value check for Pages Dictionary; - added iPres corpus test files for page tree conditions to test resources; - unit tests for page tree conditions. - added MessageConstants for page dict issues; - factored out type check for PDF dictionary; - changed message constant ERR_DOC_CAT_TYPE_NO_CAT to ERR_DOC_CAT_TYPE_INVALID; and - dedicated folder for page tree test resources.
- added catch for missing document page node.
- included page tree tests in PDF Module test suite class; - corrected date for RC PDF Module release; and - fixed spacing issues.
Codecov Report
@@ Coverage Diff @@
## integration #322 +/- ##
=================================================
+ Coverage 44.45% 44.49% +0.03%
- Complexity 3415 3419 +4
=================================================
Files 368 368
Lines 30318 30330 +12
Branches 5994 5995 +1
=================================================
+ Hits 13478 13495 +17
+ Misses 14430 14426 -4
+ Partials 2410 2409 -1
Continue to review full report at Codecov.
|
- factored out methods from `TestUtils` to address Codacy issues.
david-russo
reviewed
Mar 19, 2018
| @@ -0,0 +1,184 @@ | |||
| /** | |||
| * | |||
| */ | |||
|
|
||
| /** | ||
| * | ||
| */ |
| try { | ||
| minorVersion = getMinorVersion(this.versionString); | ||
| } catch (NumberFormatException nfe) { | ||
| // TODO : Do nothing for now, the version number is still invalid. |
There was a problem hiding this comment.
Maybe remove the TODO here since there's no instructions on what needs to be done differently in the future, and it's a special keyword for many IDEs and programmers to indicate such.
| public static final String PDF_VER1_HEADER_PREFIX = "PDF-1."; //$NON-NLS-1$ | ||
| public static final String PDF_SIG_HEADER = "%" + PDF_VER1_HEADER_PREFIX; //$NON-NLS-1$ | ||
| public static final String POSTSCRIPT_HEADER_PREFIX = "!PS-Adobe-"; //$NON-NLS-1$ | ||
| public static final int MAX_VALID_MAJOR_VERSION = 7; |
There was a problem hiding this comment.
MAX_VALID_MAJOR_VERSION looks like it should be MAX_VALID_MINOR_VERSION.
| @@ -0,0 +1,166 @@ | |||
| /** | |||
| * | |||
| */ | |||
…at-and-pagedict - PDF Module and test classes conflicts; and - test script conflicts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ArrayIndexOutOfBoundsExceptionfor page dictionary and page nodes;PDFHeaderclass;/Typekey validation for document catalog and page dictionaries;MessageConstantsfor new validation conditions;TestUtilsclass provides basic validation testing methods;Combines FIX - PDF minor version number checking. #317, FIX - Document catalog type checking #318 and FIX - Test for inconsistent xref for catalog. #319.
This PR closes PDF version checking not correct #207, closes Inconsistent catalog indirect reference and object number #208, closes Value for /Type in Document Catalog not validated #210, closes Indirect refrence to not existing object in page tree node /Kids array results in well-formed and valid #211 and closes Value for /Type in Page Tree Node not validated #212.