Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX - Handling of empty PDF CreationDate #549

Merged
merged 3 commits into from Dec 11, 2019
Merged

FIX - Handling of empty PDF CreationDate #549

merged 3 commits into from Dec 11, 2019

Conversation

carlwilson
Copy link
Member

@carlwilson
FIX - Handling of empty PDF CreationDate
72f401b 
- added a test for empty or null PDF date that doesn't throw Exception.
Fixes #267
@carlwilson carlwilson added bug A product defect that needs fixing P1 High priority issues to be scheduled in the upcoming release labels Dec 11, 2019
@carlwilson carlwilson added this to the v1.24-m4 Release milestone Dec 11, 2019
@carlwilson carlwilson self-assigned this Dec 11, 2019
@codecov
Copy link

codecov bot commented Dec 11, 2019 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (integration@5481817). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             integration     #549   +/-   ##
==============================================
  Coverage               ?   45.81%           
  Complexity             ?     1055           
==============================================
  Files                  ?       57           
  Lines                  ?     9150           
  Branches               ?     1687           
==============================================
  Hits                   ?     4192           
  Misses                 ?     4414           
  Partials               ?      544

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5481817...903cdf6. Read the comment docs.

@carlwilson carlwilson merged commit 1b63272 into integration Dec 11, 2019
@carlwilson carlwilson deleted the fix/pdf-dates branch December 11, 2019 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@carlwilson carlwilson

Labels
bug A product defect that needs fixing P1 High priority issues to be scheduled in the upcoming release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improperly formed date () when () is a valid literal
1 participant
@carlwilson