added constant in PngModule

[marti1125]

Hi @carlwilson
I am working in magic number of
extramodules/it/eng/jhove/module/png/PngModule.java

but I know what is the correct name for:

'4' is a magic number.
case 4:

[codecov]

Codecov Report

Merging #578 into integration will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             integration     #578   +/-   ##
==============================================
  Coverage          45.63%   45.63%           
  Complexity          1046     1046           
==============================================
  Files                 57       57           
  Lines               9149     9149           
  Branches            1687     1687           
==============================================
  Hits                4175     4175           
  Misses              4424     4424           
  Partials             550      550           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update becbaa8...bf7f8ef. Read the comment docs.

[carlwilson]

Hi @marti1125, thanks for this. The case statement switches on the value of "colour type", a single byte value, described in the specification here, section 4.1.1: https://www.w3.org/TR/PNG-Chunks.html.

[marti1125]

@carlwilson I added constants for color type, could you check if is it has correct name? please

[carlwilson]

Perfect, thanks

[carlwilson]

Sorry, I should have waited until I finished my tea before checking.

[marti1125]

@carlwilson could you check again please :)

[carlwilson]

Good work, merging shortly.