Update ConfigHandler.java #586
Conversation
Codecov Report
@@ Coverage Diff @@
## integration #586 +/- ##
==============================================
Coverage 45.63% 45.63%
Complexity 1046 1046
==============================================
Files 57 57
Lines 9149 9149
Branches 1687 1687
==============================================
Hits 4175 4175
Misses 4424 4424
Partials 550 550
Continue to review full report at Codecov.
|
| @@ -371,7 +371,7 @@ public InputSource resolveEntity (String publicId, String systemId) | |||
| throws SAXException, IOException { | |||
| if (systemId.endsWith (configSchemaName)) { | |||
| try { | |||
| URL resURL = this.getClass().getResource("jhoveConfig.xsd"); | |||
| URL resURL = this.getClass().getResource(configSchemaName); | |||
There was a problem hiding this comment.
+1 use of existing constant :)
| /** private String constants. */ | ||
| private static final String YES = "Yes"; | ||
| private static final String NO = "No"; | ||
| private static final String COLON = ":"; |
There was a problem hiding this comment.
The definition of the constant COLON is a classic "matter of taste" and lacks a definitive answer in lieu of a style guide. Over the years I've taken the definitive stance of wavering on this. This Stack Exchange question states the case against. If it's to be a constant, I'd adopt a name that indicates its use, in this case, TIME_SEP perhaps?
There was a problem hiding this comment.
OK, I got the one for the Niso Image Metadata. I'll update it, even if I get personal sophomoric enjoyment from using COLON as a constant. :) Not sure if I understand what is the issue/if there is an issue with ConfigHandler.java.
updated constant name as requested
| /** private String constants. */ | ||
| private static final String YES = "Yes"; | ||
| private static final String NO = "No"; | ||
| private static final String TIME_STEP = ":"; |
There was a problem hiding this comment.
I hate to do this but I meant TIME_SEP sorry, short for time separator as that's effectively its use here, sorry I know I'm fussy, it's a general developer character failing and job requirement. :)
#573