added extra encryption algorithm #621
Conversation
In the extensionlevel 3 a new encryption algorithm is allowed 256-bit AES. This commit adds that option
Extra code when the encryption algorithm is 5, because there are additional properties
When the Encryption Algorithm is 5, the fields OwnerEncryptionKey and UserEncryptionKey are mandatory
Error messages updated
jhove-modules/pdf-hul/src/main/java/edu/harvard/hul/ois/jhove/module/PdfModule.java
Outdated
Show resolved
Hide resolved
jhove-modules/pdf-hul/src/main/java/edu/harvard/hul/ois/jhove/module/PdfModule.java
Outdated
Show resolved
Hide resolved
...les/pdf-hul/src/main/resources/edu/harvard/hul/ois/jhove/module/pdf/ErrorMessages.properties
Outdated
Show resolved
Hide resolved
David Russo's suggestions
|
Thanks again @david-russo . I updated the pull request |
|
Thanks both @samalloing and @david-russo |
|
Interesting, this has broken the build. The issue is that the IDs for the message resources are mal-formed and the messages can't be loaded. I've added a review comment that requests changes. |
There was a problem hiding this comment.
See comment inline but good work overall thanks @samalloing
| @@ -153,3 +153,6 @@ PDF-HUL-147 = Page tree node not found. | |||
| PDF-HUL-148 = PDF minor version number is greater than 7. | |||
| PDF-HUL-149 = Invalid indirect destination - referenced object ''{0}'' cannot be found | |||
| PDF-HUL-150 = Cross-reference stream must be a stream | |||
| PDF_HUL_151 = Unexpected error occurred while attempting to read the cross-reference table | |||
There was a problem hiding this comment.
These are the culprits, they should be using hyphens, not underscores.
|
I updated it, sorry about the mistake @carlwilson |
Codecov Report
@@ Coverage Diff @@
## integration #621 +/- ##
==============================================
Coverage 45.63% 45.63%
Complexity 1046 1046
==============================================
Files 57 57
Lines 9149 9149
Branches 1687 1687
==============================================
Hits 4175 4175
Misses 4424 4424
Partials 550 550 Continue to review full report at Codecov.
|
No need at all, that's what the autotests are for, thanks @samalloing |
Hi @carlwilson
In this pull request I added code for a new encryption algorithm 256-bit AES. It is allowed in the extensionlevel 3 as a new encryption algorithm. This code is independent of the Extension level code I mailed you about.
Sam