Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: Basic Github Actions build #718

Merged
merged 4 commits into from Apr 6, 2022
Merged

FEAT: Basic Github Actions build #718

merged 4 commits into from Apr 6, 2022

Conversation

carlwilson
Copy link
Member

  • checkout project;
  • run mvn build and verify;
  • run the JHOVE integration tests; and
  • upload static QA to Codacy.

@carlwilson
FEAT: Basic Github Actions build
62512e8 
- checkout project;
- run mvn build and verify;
- run the JHOVE integration tests; and
- upload static QA to Codacy.
@carlwilson carlwilson added feature New functionality to be developed P1 High priority issues to be scheduled in the upcoming release RC1.26 labels Apr 6, 2022
@carlwilson carlwilson added this to the JHOVE 1.26 milestone Apr 6, 2022
@carlwilson carlwilson self-assigned this Apr 6, 2022
@codecov
Copy link

codecov bot commented Apr 6, 2022 •
edited

Codecov Report

Merging #718 (1329b50) into integration (2d6c519) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             integration     #718   +/-   ##
==============================================
  Coverage          45.63%   45.63%           
  Complexity          1046     1046           
==============================================
  Files                 57       57           
  Lines               9144     9144           
  Branches            1682     1682           
==============================================
  Hits                4173     4173           
  Misses              4422     4422           
  Partials             549      549

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d6c519...1329b50. Read the comment docs.

@carlwilson
FEAT: Coverage reports
9e6c94c 
- fixed commands for coverage generation; and
- disabled travis for all but master and integration.
@carlwilson
FIX: Remove broken Java 11 test.
115009e
@carlwilson
FEAT: Github actions
1329b50 
- reinstated Java 11 build sans integration tests; and
- added conditionals for only testing on Java 8.
@carlwilson carlwilson merged commit aa7350e into integration Apr 6, 2022
@carlwilson carlwilson deleted the feat/gh-actions branch April 6, 2022 23:04
@CGarces
Copy link
Contributor

CGarces commented Dec 7, 2022

Hi @carlwilson

Matrix is declared on the build job

    strategy:
      matrix:
        java-version: [8, 11]

But if: matrix.java-version == 8 is used on the coverage section. I think that this will never work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@carlwilson carlwilson

Labels
feature New functionality to be developed P1 High priority issues to be scheduled in the upcoming release
Projects
None yet
Milestone
JHOVE 1.26
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@carlwilson @CGarces