MERGE: PR 634 XML-hul code review fixes #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The module now correctly handles schemaLocations that define multiple namespace-to-location relationships, instead of lumping them all into the first namespace's schema location. This change also correctly reports noNamespaceSchemaLocation values as the schema's location, instead of its namespace URI.
All parameter parsing has been moved to a single location, and we now log warnings for unrecognized parameters, as well as parameter argument which include invalid URI syntax or unresolvable file paths. A misleading schema example was also removed from the default config files, which could be better illustrated in module documentation.
This prevented processing of any XML files with local schema URIs.
Includes: - Clarified, corrected and expanded documentation - Modernized code constructs (e.g. loops, auto-boxing) - Removal of unnecessary overrides and unused code - Clearer code formatting - Javadoc fixes
Codecov Report
@@ Coverage Diff @@
## integration #724 +/- ##
=================================================
- Coverage 45.75% 45.69% -0.06%
+ Complexity 1051 1049 -2
=================================================
Files 57 57
Lines 9145 9145
Branches 1684 1684
=================================================
- Hits 4184 4179 -5
- Misses 4405 4408 +3
- Partials 556 558 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration merge for #634 submitted by @david-russo, many thanks.