Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Configurable language codes #729

Merged
merged 1 commit into from Apr 13, 2022
Merged

Conversation

carlwilson
Copy link
Member

  • added <languageCode> element to jhoveConfig.xsd and ConfigHandler;
  • set the module.language property in JhoveBase;
  • changed config schema location to OPF servers;
  • tests for ConfigHandler language, including defaults for bad values; and
  • tidied ConfigHandler formatting some.

This builds on the work done by @leefrank9527 in #693, thanks. Closes #643

- added `<languageCode>` element to `jhoveConfig.xsd` and `ConfigHandler`;
- set the `module.language` property in `JhoveBase`;
- changed config schema location to OPF servers;
- tests for ConfigHandler language, including defaults for bad values; and
- tidied `ConfigHandler` formatting some.
@carlwilson carlwilson added the feature New functionality to be developed label Apr 13, 2022
@carlwilson carlwilson added this to the JHOVE 1.26 milestone Apr 13, 2022
@carlwilson carlwilson self-assigned this Apr 13, 2022
@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

Merging #729 (f9580a3) into integration (1b9858b) will increase coverage by 0.04%.
The diff coverage is 55.29%.

@@                Coverage Diff                @@
##             integration     #729      +/-   ##
=================================================
+ Coverage          46.46%   46.51%   +0.04%     
- Complexity          1054     1057       +3     
=================================================
  Files                 57       57              
  Lines               9059     9073      +14     
  Branches            1606     1609       +3     
=================================================
+ Hits                4209     4220      +11     
- Misses              4308     4310       +2     
- Partials             542      543       +1     
Impacted Files Coverage Δ
...main/java/edu/harvard/hul/ois/jhove/JhoveBase.java 42.13% <0.00%> (-0.18%) ⬇️
.../java/edu/harvard/hul/ois/jhove/ConfigHandler.java 61.41% <56.62%> (+3.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b2ef15...f9580a3. Read the comment docs.

@carlwilson carlwilson merged commit a7b5e29 into integration Apr 13, 2022
@carlwilson carlwilson deleted the feat/language-selection branch April 13, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality to be developed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch language?
2 participants