String property can be empty #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hat they are encrypted instead of not shown
carlwilson
requested changes
Nov 30, 2022
| if (type == PropertyType.STRING) { | ||
| // a String value can be empty | ||
| value = ""; | ||
| } else { |
There was a problem hiding this comment.
The else is unnecessary if it's not a string then we always want the exception which terminates.
carlwilson
requested changes
Nov 30, 2022
| throw new NullPointerException (CoreMessageConstants.EXC_PROP_VAL_NULL); | ||
| if (type == PropertyType.STRING) { | ||
| // a String value can be empty | ||
| value = ""; |
There was a problem hiding this comment.
Look at the Codacy feedback. It might be a good idea not to reassign value and add an intermediary value instead. Parameter mutation is rarely a good thing ;)
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @carlwilson
In PDF files the String Properties like Title can be empty. Now the value is null and will give a nullpointerexception when that happens. I updated the jHove Property, but I could also only update the addStringProperty in PDF module.
Sam