Migration mechanism development #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extract `create_app_meta` to the utils to reuse it.
- Migration runner stub
- Add filename arg to `create_app_meta` func
- Stubs for run_migrations & related tests
- Remove unneeded MigrationProcessRunner
- Fix mock path in the tests.base
- Remove obsolete info from the docstring
- Add migrate entrypoint
- app_meta constructing refactor
- Optimize `read_yaml`
- Use only app_meta filepath as param for `create_app_meta`
- Comment on argparse usage
- create_app_meta test
- Introduce `dump_dict_to_tempfile`
- Rename entrypoint
- run_migrations -> run_migrations_console_entrypoint
- run_migrations_console_entrypoint + test
- Add missing whitespaces after columns
- path_to_kv util
- collect_packages_for_migration util
- path_to_kv test for no results
- Define scheme for the DB URL
- Migration entrypoints logic
Pull Request Test Coverage Report for Build 2852
💛 - Coveralls |
bdmbdsm
commented
Dec 20, 2018
| @@ -14,30 +16,38 @@ | |||
|
|
|||
| from openprocurement.api.utils import ( | |||
| apply_data_patch, | |||
| calculate_business_date, | |||
There was a problem hiding this comment.
не зміг втриматись, посортував імпорти)
bdmbdsm
commented
Dec 20, 2018
|
Jenkins - OK |
leits
approved these changes
Dec 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create_app_metato the utils to reuse it.create_app_metafuncread_yamlcreate_app_metadump_dict_to_tempfileThis change is