koatuu_additional_classification #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leits
reviewed
Aug 9, 2018
| @@ -292,10 +294,10 @@ def suite(): | |||
| suite.addTest(unittest.makeSuite(AuctionAuctionResourceTestWithRegistry)) | |||
| suite.addTest(unittest.makeSuite(AuctionBidInvalidationAuctionResourceTestWithRegistry)) | |||
| suite.addTest(unittest.makeSuite(AuctionSameValueAuctionResourceTestWithRegistry)) | |||
| suite.addTest(unittest.makeSuite(AuctionSubmissionMethodDetailsTestWithRegistry)) | |||
| #suite.addTest(unittest.makeSuite(AuctionSubmissionMethodDetailsTestWithRegistry)) | |||
There was a problem hiding this comment.
Потрібно або забрати, або лишити
Коментувати код - погана ідея
|
|
||
|
|
||
|
|
||
| def koatuu_additional_classification(self): |
There was a problem hiding this comment.
Якщо ми відтестуємо це на рівня валідатора у api i моделі у auctions.core, тоді не потрібно тестувати у кінцевому пакеті
There was a problem hiding this comment.
але навіщо це тестувати для API або CORE, якщо його використовує кілька пакетів (2)
leits
approved these changes
Aug 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is