-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add rectification period dgfOtherAssets #112
Conversation
It's probably outdated, and also takes a lot of lines.
@@ -10,3 +10,5 @@ | |||
|
|||
DEFAULT_PROCUREMENT_METHOD_TYPE_OTHER = "DGFOtherAssets" | |||
DEFAULT_PROCUREMENT_METHOD_TYPE_FINANCIAL = "DGFFinancialAssets" | |||
|
|||
RECTIFICATION_PERIOD_LENGTH_DAYS = 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Тут одразу повинна бути timedelta
i змінна тоді RECTIFICATION_PERIOD_DURATION
now = get_now() | ||
if self.status == 'active.tendering': | ||
if ( | ||
now >= self.rectificationPeriod.startDate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Чому б не використати тут впроваджене тобою in
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Це якщо є цей період. У старих процедур його не буде
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Точно! Я на цьому місці його і придумав, а тепер забув.
Depends on openprocurement/openprocurement.auctions.core#160
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)