Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rectification period v2 #113

Merged
merged 2 commits into from
Aug 16, 2018
Merged

Add rectification period v2 #113

merged 2 commits into from
Aug 16, 2018

Conversation

bdmbdsm
Copy link
Contributor

@bdmbdsm bdmbdsm commented Aug 16, 2018

By using git reset and git add --patch I've accomplished to turn a couple of my previous commits into two: first consists of style changes, second one stands for real rectificationPeriod adoption. Must admit, that I've haven't been able to separate then cleanly to organize them into separate PRs. I mean, that tests of first commit are failing, so you're welcome to check this PR by commit 🙂

This change is Reviewable

@bdmbdsm bdmbdsm self-assigned this Aug 16, 2018
@bdmbdsm bdmbdsm requested a review from leits August 16, 2018 14:05
@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 81.995% when pulling bf6a213 on bdmbdsm:add-rectification-period-v2 into 557c3f8 on openprocurement:master.

@leits leits merged commit ed2bf81 into openprocurement:master Aug 16, 2018
@bdmbdsm bdmbdsm deleted the add-rectification-period-v2 branch August 17, 2018 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants