Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add edr client #62

Merged
merged 4 commits into from Apr 13, 2017
Merged

Add edr client #62

merged 4 commits into from Apr 13, 2017

Conversation

Krokop
Copy link
Contributor

@Krokop Krokop commented Mar 31, 2017

Потрібен для openprocurement/robot_tests#494


This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.01%) to 69.272% when pulling 7fbee6d on ITVaan:add_edr_client into 6cd01c4 on openprocurement:master.

@selurvedu
Copy link
Contributor

Є лише одне зауваження, в решті все ОК.


Reviewed 1 of 1 files at r1.
Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


openprocurement_client/client.py, line 650 at r1 (raw file):

    """ Client for validate members by EDR """

    def __init__(self, host_url, username, password='', **kwargs):

Згідно з http://edr.api-docs.openprocurement.org/en/latest/authentication.html, доступ до API не буде працювати без пароля (на відміну від API тендерів). Варто зробити параметр password обов'язковим.


Comments from Reviewable

@selurvedu
Copy link
Contributor

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


Comments from Reviewable

@Krokop
Copy link
Contributor Author

Krokop commented Apr 13, 2017

openprocurement_client/client.py, line 650 at r1 (raw file):

Previously, selurvedu wrote…

Згідно з http://edr.api-docs.openprocurement.org/en/latest/authentication.html, доступ до API не буде працювати без пароля (на відміну від API тендерів). Варто зробити параметр password обов'язковим.

Done


Comments from Reviewable

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.01%) to 69.272% when pulling e6cb1f9 on ITVaan:add_edr_client into 6cd01c4 on openprocurement:master.

@selurvedu
Copy link
Contributor

:lgtm:


Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@selurvedu selurvedu merged commit e6cb1f9 into openprocurement:master Apr 13, 2017
selurvedu added a commit that referenced this pull request Apr 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants