Skip to content

Commit

Permalink
update tests: rationaleType > rationaleTypes
Browse files Browse the repository at this point in the history
  • Loading branch information
@vmaksymiv
vmaksymiv committed May 26, 2016
1 parent 41167a1 commit b3e547f
Show file tree
Hide file tree
Showing 2 changed files with 44 additions and 13 deletions.
55 changes: 43 additions & 12 deletions openprocurement/contracting/api/tests/change.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def test_get_change(self):
'rationale_ru': u'ff',
'rationale_en': 'asdf',
'contractNumber': 12,
'rationaleType': 'priceReduction'}})
'rationaleTypes': ['priceReduction']}})
self.assertEqual(response.status, '201 Created')
self.assertEqual(response.content_type, 'application/json')
change = response.json['data']
Expand All @@ -65,14 +65,14 @@ def test_get_change(self):
self.assertIn('changes', response.json['data'])
self.assertEqual(len(response.json['data']['changes']), 1)
self.assertEqual(set(response.json['data']['changes'][0].keys()),
set(['id', 'date', 'status', 'rationaleType', 'rationale', 'rationale_ru', 'rationale_en', 'contractNumber']))
set(['id', 'date', 'status', 'rationaleTypes', 'rationale', 'rationale_ru', 'rationale_en', 'contractNumber']))

self.app.authorization = None
response = self.app.get('/contracts/{}/changes'.format(self.contract['id']))
self.assertEqual(response.status, '200 OK')
self.assertEqual(len(response.json['data']), 1)
self.assertEqual(set(response.json['data'][0].keys()),
set(['id', 'date', 'status', 'rationaleType', 'rationale', 'rationale_ru', 'rationale_en', 'contractNumber']))
set(['id', 'date', 'status', 'rationaleTypes', 'rationale', 'rationale_ru', 'rationale_en', 'contractNumber']))

def test_create_change_invalid(self):
response = self.app.post('/contracts/{}/changes?acc_token={}'.format(self.contract['id'], self.contract_token),
Expand All @@ -86,12 +86,12 @@ def test_create_change_invalid(self):
response = self.app.post_json('/contracts/{}/changes?acc_token={}'.format(self.contract['id'], self.contract_token),
{'data': {}}, status=422)
self.assertEqual(response.json['errors'], [
{"location": "body", "name": "rationaleType", "description": ["This field is required."]},
{"location": "body", "name": "rationaleTypes", "description": ["This field is required."]},
{"location": "body", "name": "rationale", "description": ["This field is required."]}
])

response = self.app.post_json('/contracts/{}/changes?acc_token={}'.format(self.contract['id'], self.contract_token),
{'data': {'rationale': "", 'rationaleType': 'volumeCuts'}}, status=422)
{'data': {'rationale': "", 'rationaleTypes': ['volumeCuts']}}, status=422)
self.assertEqual(response.json['errors'], [
{"location": "body", "name": "rationale", "description": ["String value is too short."]}
])
Expand All @@ -112,7 +112,7 @@ def test_create_change_invalid(self):
self.assertEqual(response.status, '403 Forbidden')

response = self.app.patch_json('/contracts/{}?acc_token={}'.format(self.contract['id'], self.contract_token),
{'data': {'changes': [{'rationale': "penguin", 'rationaleType': 'volumeCuts'}]}})
{'data': {'changes': [{'rationale': "penguin", 'rationaleTypes': ['volumeCuts']}]}})
self.assertEqual(response.status, '200 OK')
self.assertEqual(response.body, 'null')

Expand All @@ -124,7 +124,7 @@ def test_create_change(self):
response = self.app.post_json('/contracts/{}/changes?acc_token={}'.format(self.contract['id'], self.contract_token),
{'data': {'rationale': u'причина зміни укр',
'rationale_en': 'change cause en',
'rationaleType': 'qualityImprovement'}})
'rationaleTypes': ['qualityImprovement']}})
self.assertEqual(response.status, '201 Created')
self.assertEqual(response.content_type, 'application/json')
change = response.json['data']
Expand All @@ -136,7 +136,7 @@ def test_create_change(self):
self.assertEqual(len(response.json['data']), 1)

response = self.app.post_json('/contracts/{}/changes?acc_token={}'.format(self.contract['id'], self.contract_token),
{'data': {'rationale': u'трататата', 'rationaleType': 'priceReduction'}}, status=403)
{'data': {'rationale': u'трататата', 'rationaleTypes': ['priceReduction']}}, status=403)
self.assertEqual(response.status, '403 Forbidden')
self.assertEqual(response.json['errors'], [
{"location": "body", "name": "data", "description": "Can't create new contract change while any (pending) change exists"}
Expand All @@ -148,7 +148,14 @@ def test_create_change(self):
self.assertEqual(response.json['data']['status'], 'active')

response = self.app.post_json('/contracts/{}/changes?acc_token={}'.format(self.contract['id'], self.contract_token),
{'data': {'rationale': u'трататата', 'rationaleType': 'priceReduction'}})
{'data': {'rationale': u'трататата', 'rationaleTypes': ['non-existing-rationale']}}, status=422)
self.assertEqual(response.status, '422 Unprocessable Entity')
self.assertEqual(response.json['errors'], [
{"location": "body", "name": "rationaleTypes", "description": [["Value must be one of ['volumeCuts', 'itemPriceVariation', 'qualityImprovement', 'thirdParty', 'durationExtension', 'priceReduction', 'taxRate', 'fiscalYearExtension']."]]}
])

response = self.app.post_json('/contracts/{}/changes?acc_token={}'.format(self.contract['id'], self.contract_token),
{'data': {'rationale': u'трататата', 'rationaleTypes': ['priceReduction']}})
self.assertEqual(response.status, '201 Created')
change2 = response.json['data']
self.assertEqual(change2['status'], 'pending')
Expand All @@ -161,7 +168,7 @@ def test_patch_change(self):
response = self.app.post_json('/contracts/{}/changes?acc_token={}'.format(self.contract['id'], self.contract_token),
{'data': {'rationale': u'причина зміни укр',
'rationale_en': u'change cause en',
'rationaleType': 'priceReduction',
'rationaleTypes': ['priceReduction'],
'contractNumber': u'№ 146'}})
self.assertEqual(response.status, '201 Created')
self.assertEqual(response.content_type, 'application/json')
Expand Down Expand Up @@ -191,9 +198,33 @@ def test_patch_change(self):
self.assertEqual(first_patch_date, second_patch_date)

response = self.app.patch_json('/contracts/{}/changes/{}?acc_token={}'.format(self.contract['id'], change['id'], self.contract_token),
{'data': {'rationaleType': 'fiscalYearExtension'}})
{'data': {'rationaleTypes': ['fiscalYearExtension', 'priceReduction']}})
self.assertEqual(response.status, '200 OK')
self.assertEqual(response.json['data']['rationaleTypes'], ['fiscalYearExtension', 'priceReduction'])

response = self.app.patch_json('/contracts/{}/changes/{}?acc_token={}'.format(self.contract['id'], change['id'], self.contract_token),
{'data': {'rationaleTypes': ['fiscalYearExtension', 'volumeCuts', 'taxRate']}})
self.assertEqual(response.status, '200 OK')
self.assertEqual(response.json['data']['rationaleTypes'], ['fiscalYearExtension', 'volumeCuts', 'taxRate'])

response = self.app.patch_json('/contracts/{}/changes/{}?acc_token={}'.format(self.contract['id'], change['id'], self.contract_token),
{'data': {'rationaleTypes': 'fiscalYearExtension'}})
self.assertEqual(response.status, '200 OK')
self.assertEqual(response.json['data']['rationaleType'], 'fiscalYearExtension')
self.assertEqual(response.json['data']['rationaleTypes'], ['fiscalYearExtension'])

response = self.app.patch_json('/contracts/{}/changes/{}?acc_token={}'.format(self.contract['id'], change['id'], self.contract_token),
{'data': {'rationaleTypes': 'fiscalYearExtension, volumeCuts'}}, status=422)
self.assertEqual(response.status, '422 Unprocessable Entity')
self.assertEqual(response.json['errors'], [
{"location": "body", "name": "rationaleTypes", "description": [["Value must be one of ['volumeCuts', 'itemPriceVariation', 'qualityImprovement', 'thirdParty', 'durationExtension', 'priceReduction', 'taxRate', 'fiscalYearExtension']."]]}
])

response = self.app.patch_json('/contracts/{}/changes/{}?acc_token={}'.format(self.contract['id'], change['id'], self.contract_token),
{'data': {'rationaleTypes': []}}, status=422)
self.assertEqual(response.status, '422 Unprocessable Entity')
self.assertEqual(response.json['errors'], [
{"location": "body", "name": "rationaleTypes", "description": ["Please provide at least 1 item."]}
])

response = self.app.patch_json('/contracts/{}/changes/{}?acc_token={}'.format(self.contract['id'], change['id'], self.contract_token),
{'data': {'id': '1234' * 8}})
Expand Down
2 changes: 1 addition & 1 deletion openprocurement/contracting/api/tests/document.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ def test_contract_change_document(self):
response = self.app.post_json('/contracts/{}/changes?acc_token={}'.format(self.contract['id'], self.contract_token),
{'data': {'rationale': u'причина зміни укр',
'rationale_en': 'change cause en',
'rationaleType': 'priceReduction'}})
'rationaleTypes': ['priceReduction']}})
self.assertEqual(response.status, '201 Created')
self.assertEqual(response.content_type, 'application/json')
change = response.json['data']
Expand Down

0 comments on commit b3e547f

Please sign in to comment.