Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a407828329451172 calculation of client payments #61

Closed
wants to merge 11 commits into from
Closed

a407828329451172 calculation of client payments #61

wants to merge 11 commits into from

Conversation

Tuoris
Copy link
Contributor

@Tuoris Tuoris commented Aug 16, 2017

No description provided.

@coveralls
Copy link

coveralls commented Aug 16, 2017 •
edited

Coverage Status

Coverage increased (+0.09%) to 95.666% when pulling 42a97c9 on Tuoris:a407828329451172_calculate_payments into 214d1a3 on openprocurement:npv_calculation.

@coveralls
Copy link

coveralls commented Aug 16, 2017 •
edited

Coverage Status

Coverage increased (+0.09%) to 95.666% when pulling d5d4e43 on Tuoris:a407828329451172_calculate_payments into 214d1a3 on openprocurement:npv_calculation.

@Tuoris Tuoris force-pushed the a407828329451172_calculate_payments branch from d5d4e43 to 746f856 Compare August 16, 2017 14:29
@coveralls
Copy link

coveralls commented Aug 16, 2017 •
edited

Coverage Status

Coverage increased (+0.09%) to 95.666% when pulling 746f856 on Tuoris:a407828329451172_calculate_payments into 214d1a3 on openprocurement:npv_calculation.

annawzz
annawzz reviewed Aug 17, 2017
View reviewed changes
openprocurement/tender/esco/tests/npv_blanks.py Outdated

def client_payment(self):

# Predefined values
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

винеси тестові дані в окремий файл

openprocurement/tender/esco/npv_calculation.py Outdated
days_for_discount_rate):
'''Calculates client payments to a participant'''

lists = zip(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/openprocurement/openprocurement.tender.esco/pull/60/files#r133735992

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а може ще якось і без зіпу?)

Copy link
Contributor Author

@Tuoris Tuoris Aug 18, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ні)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

та ні, зроби таки без використання зіпу.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.python.org/2/library/functions.html#zip

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@coveralls
Copy link

coveralls commented Aug 18, 2017 •
edited

Coverage Status

Coverage increased (+0.1%) to 95.725% when pulling 461669c on Tuoris:a407828329451172_calculate_payments into c5b1cb9 on openprocurement:npv_calculation.

annawzz
annawzz reviewed Aug 18, 2017
View reviewed changes
openprocurement/tender/esco/tests/npv_test_data.py Outdated
@@ -28,3 +28,24 @@
'second_test': [Fraction(str(0))]*21,
'third_test': [Fraction(str(0.12500))] * 21
}

CLIENT_PAYMENT_DATA = {
'yearly_percentage': 70,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

подавай відсоток у вигляді 0.7, потрібно переробити під це логіку

@coveralls
Copy link

coveralls commented Aug 18, 2017 •
edited

Coverage Status

Coverage increased (+0.1%) to 95.725% when pulling b93c025 on Tuoris:a407828329451172_calculate_payments into c5b1cb9 on openprocurement:npv_calculation.

@annawzz
Copy link
Collaborator

annawzz commented Aug 18, 2017

конфлікти.

@coveralls
Copy link

coveralls commented Aug 18, 2017 •
edited

Coverage Status

Coverage increased (+0.09%) to 95.732% when pulling 6c1698f on Tuoris:a407828329451172_calculate_payments into e8e05fc on openprocurement:npv_calculation.

@vmaksymiv
Copy link
Member

@Tuoris чи розумієш ти поставлену задачу?

@Tuoris
Copy link
Contributor Author

Tuoris commented Aug 18, 2017 •
edited

@vmaksymiv, так

@vmaksymiv
Copy link
Member

@Tuoris розкажи

@Tuoris
Copy link
Contributor Author

Tuoris commented Aug 18, 2017

Потрібно обчислити платежі Замовника на користь Учасника. Для цього потрібен відсоток платежів на користь Учасника помножити на скорочення витрат Замовника, помножити на кількість днів дії пропозиції учасника в відповідному періоді і поділити на кількість днів періоду для обчислення ставки дисконтування.

@coveralls
Copy link

coveralls commented Aug 21, 2017 •
edited

Coverage Status

Coverage increased (+0.09%) to 95.735% when pulling 1eb261f on Tuoris:a407828329451172_calculate_payments into e8e05fc on openprocurement:npv_calculation.

@Tuoris
Copy link
Contributor Author

Tuoris commented Aug 29, 2017

Closed due to moving npv_calculation to separate package.

@Tuoris Tuoris closed this Aug 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annawzz annawzz annawzz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Tuoris @coveralls @annawzz @vmaksymiv