A429024013052686 add tender tests #67
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmaksymiv
reviewed
Sep 15, 2017
| @@ -704,3 +704,27 @@ def tender_submission_method_details_no_auction_only(self): | |||
| self.assertEqual(response.status, '200 OK') | |||
| self.assertEqual(response.content_type, 'application/json') | |||
| self.assertEqual(response.json['data']['submissionMethodDetails'], "quick(mode:no-auction)") | |||
|
|
|||
| def validate_items(self): | |||
| my_data = deepcopy(self.initial_data) | |||
|
|
||
| self.assertEqual(response.status, '201 Created') | ||
| self.assertEqual(response.content_type, 'application/json') | ||
| self.assertEqual(response.json['data']['submissionMethodDetails'], "quick(mode:no-auction)") |
There was a problem hiding this comment.
"quick(mode:no-auction)" це обов'язково мати для тестування items?
|
|
||
| def validate_items(self): | ||
| my_data = deepcopy(self.initial_data) | ||
| my_data["items"][0]["classification"]["id"] = u"33693100-5" |
| my_data["items"][0]["classification"]["id"] = u"92332000-7" | ||
| my_data["items"].append(deepcopy(my_data["items"][0])) | ||
| my_data["items"][1]["classification"]["id"] = u"92340000-6" | ||
| my_data["revisions"] = [] |
There was a problem hiding this comment.
revisions ? для чого його встановлювати?
vladkhard
force-pushed
the
a429024013052686_add_tender_tests
branch
8 times, most recently
from
519a267
to
c1f8ad7
Compare
vmaksymiv
reviewed
Sep 19, 2017
| @@ -732,3 +732,24 @@ def tender_submission_method_details_no_auction_only(self): | |||
| self.assertEqual(response.status, '200 OK') | |||
| self.assertEqual(response.content_type, 'application/json') | |||
| self.assertEqual(response.json['data']['submissionMethodDetails'], "quick(mode:no-auction)") | |||
|
|
|||
| def validate_items(self): | |||
There was a problem hiding this comment.
Аналогічних перевірок в інших процедурах нема? Якщо немає, то є смисл перенести цей тест в базовий пакет і включити його у всіх процедурах.
vladkhard
force-pushed
the
a429024013052686_add_tender_tests
branch
from
c1f8ad7
to
d211944
Compare
vladkhard
force-pushed
the
a429024013052686_add_tender_tests
branch
from
d211944
to
c9e6fc4
Compare
vladkhard
force-pushed
the
a429024013052686_add_tender_tests
branch
from
c9e6fc4
to
b9fa4f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.