A378485729286118 models test #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leits
commented
Jul 31, 2017
| ['startDate', 'endDate']) | ||
| period.startDate += timedelta(3) | ||
| with self.assertRaises(DataError): | ||
| period.validate() # {"startDate": ["period should begin before its end"]} |
There was a problem hiding this comment.
Спробуй тут теж через assertRaisesRegexp
| ['startDate']) | ||
| period.endDate = now | ||
| period.validate() | ||
| self.assertEqual(period.serialize().keys(), |
There was a problem hiding this comment.
Добре перевіряти одразу із вмістом через assertDictEqual, що окрім відсутності зміни ключів, записані правильні значення.
Тут і нижче
|
Притягнув свіжу версію schematics, треба поправити імпорти. ( див. у Travis CI check) |
|
Changes Unknown when pulling 0afb0c6 on sasha-kantoriz:a378485729286118_models_test into ** on openprocurement:master**. |
bubanoid
pushed a commit
to bubanoid/openregistry.api
that referenced
this pull request
Aug 3, 2017
…ement Add entrypoint 'openregistry.tests'
bubanoid
pushed a commit
to bubanoid/openregistry.api
that referenced
this pull request
Aug 3, 2017
…ement Add entrypoint 'openregistry.tests'
ivanka-jakimchuk
pushed a commit
to ivanka-jakimchuk/openregistry.api
that referenced
this pull request
Aug 4, 2017
Currency should be only UAH
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.