Function for creating blacklist from STATUS_CHANGES #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yarsanich
reviewed
Oct 4, 2017
openregistry/api/tests/base.py
Outdated
| for status in statuses: | ||
| status_blacklist[status] = {} | ||
| for auth_role in ['lot_owner', 'Administrator', 'convoy', 'concierge']: | ||
| status_blacklist[status][auth_role] = [] |
There was a problem hiding this comment.
list comprehension instead.
oleksiyVeretiuk
force-pushed
the
443892497425554_create_blacklist
branch
from
4f69742
to
a843b0a
Compare
oleksiyVeretiuk
force-pushed
the
443892497425554_create_blacklist
branch
from
a843b0a
to
84e85aa
Compare
yarsanich
reviewed
Oct 5, 2017
openregistry/api/tests/base.py
Outdated
| @@ -33,6 +34,24 @@ def snitch(func): | |||
| 'test_' + func.func_name, closure=func.func_closure) | |||
|
|
|||
|
|
|||
| def create_blacklist(status_changes, statuses, roles): | |||
| # This cycle generate black list for every status and | |||
There was a problem hiding this comment.
Напиши цей коментар через '''
yarsanich
reviewed
Oct 5, 2017
openregistry/api/tests/base.py
Outdated
| if auth_role in status_changes[status]['next_status'][w]] | ||
| }) | ||
| if auth_role in status_changes[status]['editing_permissions']: | ||
| status_blacklist[status][auth_role].append(status) |
There was a problem hiding this comment.
Назва змінної в цьому випадку не відповідає її призначенню. Ти спочатку записуєш в status_blacklist статуси в які можна перейти і називаються вони white_list?
There was a problem hiding this comment.
Краще хай то буде окремий dict, але називатиметься white_list. А в кінці statuses - white_list.
oleksiyVeretiuk
force-pushed
the
443892497425554_create_blacklist
branch
from
84e85aa
to
2c8f37b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.