change quantity to DecimalType #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yarsanich
reviewed
Oct 17, 2017
openregistry/api/tests/models.py
Outdated
| @@ -263,7 +263,7 @@ def test_Item_model(self): | |||
| "name": u"item", | |||
| "code": u"39513200-3" | |||
| }, | |||
| "quantity": 5, | |||
| "quantity": u'0', | |||
There was a problem hiding this comment.
Додав функціональність Decimal, а тестуєш 0?
|
prozorro-sale/openprocurement.api@f526a4f#diff-351c2e47636703a5ac5e7bf20fcee615R1006 |
vladkhard
force-pushed
the
a451532442394170_decimal_types
branch
from
15cde98
to
bd084ee
Compare
vladkhard
force-pushed
the
a451532442394170_decimal_types
branch
from
bd084ee
to
0793c17
Compare
vladkhard
force-pushed
the
a451532442394170_decimal_types
branch
from
0793c17
to
2f6179c
Compare
leits
reviewed
Oct 19, 2017
openregistry/api/tests/models.py
Outdated
| self.assertEqual(Decimal('0.556'), dt.to_native('0.55555')) | ||
|
|
||
| for number in ('-1.0', '11.0'): | ||
| with self.assertRaises(ConversionError): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.