Update test json with lotIdentifier #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Тести не проходять. |
…try.api into 483469047886510_update_test_data
yarsanich
reviewed
Nov 28, 2017
openregistry/api/tests/utils.py
Outdated
| # Make sorting because get_revision_changes can return | ||
| # proper results but ordering will be differ from expected result | ||
| # and test will fail | ||
| result = sorted(result, key=lambda r: r['path']) |
There was a problem hiding this comment.
краще .sort() швидше буде виконуватись
yarsanich
approved these changes
Nov 29, 2017
oleksiyVeretiuk
force-pushed
the
483469047886510_update_test_data
branch
from
a77ad5b
to
3870f8d
Compare
|
Changes Unknown when pulling 3870f8d on oleksiyVeretiuk:483469047886510_update_test_data into ** on openprocurement:master**. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
тести не проходили через те, що по-перше порядок елементів в списках result й expected_result не співпадав, а також через те що дані в expected_result не мали ключа "value" заповненого даними для тесту.
Виправлено тут a77ad5b